Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the tooltip to show the rest of the content of category and cou… #1176

Merged
merged 1 commit into from Oct 8, 2018

Conversation

vikas-cis-zz
Copy link

…ntry

@vikas-cis-zz
Copy link
Author

@vikas-cis-zz
Copy link
Author

@zaSmilingIdiot I have added tooltip for the content of category to show, let me know if that looks good :)

Thanks

@zaSmilingIdiot
Copy link
Collaborator

@vikas-cis The change in itself is perfectly fine, however:

I suspect there might be a comment missing in PD-363. If I remember correctly, the discussion had on this item included the ability to show only the top level category items in the menu initially, and then when clicked on, a top level category would expand to show the sub-category items. @AllienWorks I'm hoping you might have some further clarity on this: do you recall if this was the case or if that requirement was meant to be moved to another issue?

@vikas-cis-zz
Copy link
Author

@zaSmilingIdiot may be that change is not included in this bug list or whatever :P :D
thanks

@zaSmilingIdiot
Copy link
Collaborator

My previous comment on this has been resolved: a new issue will be created for the changing of menu options between category and sub-category menu items. Which leaves this change to only cater for adding the tooltip to the menu options.

@zaSmilingIdiot zaSmilingIdiot merged commit fe54167 into particl:market Oct 8, 2018
@AllienWorks AllienWorks deleted the category_content_fix branch October 8, 2018 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants