Listing filtering #1272
Listing filtering #1272
Conversation
vikas-cis-zz
force-pushed
the
listing_filtering
branch
from
816a6e9
to
7f59dea
Compare
|
@vikas-cis Is this still waiting for changes from the particl-marketplace codebase to be implemented/fixed? |
I think so, but just wondering have you tested it ? |
|
@zaSmilingIdiot are you running the marketplace manually ? Thanks |
|
@zaSmilingIdiot there are changes has been made in this branch for template search, If you are not running the latest develop branch code then I think you will get error in console for sure :P :D Thanks |
|
@vikas-cis Ah, no. develop branch of the marketplace? |
|
@zaSmilingIdiot yes afaik the laz branch has been merged in develop branch Thanks |
|
@vikas-cis I'll give the code a quick look overview, and we can chat offline about any changes needed. I'm not necessairly going to merge the changes yet though, until particl/particl-market#333 has been merged. I'm just mentioning this for why I removed the 'ready for review' tag. |
|
@zaSmilingIdiot yeah ofcourse I still need to test the branch again has yesterday I am facing issue and it was fixed via laz so going to give a quick check on it Thanks |
|
Jumping issue with content just fixed @vikas-cis. That wraps it for me :) |
|
Thanks @AllienWorks Will check it out in a bit |
|
ok @zaSmilingIdiot we are good to go now the below PR from marketplace did it for us. |
|
https://particl.atlassian.net/browse/PBD-176 Thanks |
Merge branch 'market-beta' of https://github.com/particl/particl-desktop into listing_filtering
… listing template; * re-works some extraneous method calls for conciseness and better readability; * Adds a max file size for uploaded images (currently set at 2MB) - base64 encoding of large images (6+ MB) seems to cause a max stack call size failure for regex processing in html sanitization (my changes may have resulted in this, but another issue does exist for a possible resulting issue as well); * Updates some of the template processing (when creating a new listing) to be promise-based instead of based on observables, to make clear the sequential processing of events and prevent excessive nested callback subscriptions processing.
…have been published).
|
Hye @zaSmilingIdiot I have tested with different scenarios add listing , update listing , publish un-published listing , edit listing and it seems working well to me so now we can merge this branch . I have tested with marketplace running mannually Thanks |
https://particl.atlassian.net/browse/PD-367