Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release/1.1.0 rc2 #731

Merged
merged 27 commits into from Jan 23, 2018
Merged

Release/1.1.0 rc2 #731

merged 27 commits into from Jan 23, 2018

Conversation

kewde
Copy link
Collaborator

@kewde kewde commented Jan 20, 2018

No description provided.

pciavald and others added 10 commits January 17, 2018 21:11
@pciavald
package version
27b60c8
@pciavald
Merge branch 'dev' into release/1.1.0-RC2
6ba1979
@pciavald
Merge branch 'dev' into release/1.1.0-RC2
e1b8169
@pciavald
Merge branch 'dev' into release/1.1.0-RC2
77d57fc
@pciavald
Merge branch 'dev' into release/1.1.0-RC2
e5af40e
@pciavald
Merge branch 'feature/zap' into release/1.1.0-RC2
b27b7f5
@tecnovert
Fix "create/restore wallet" modal when wallet exists.
ae5a3af 
Fix coldstaking paused message when wallet is uncrypted.
issue #723 Wallet -> Desktop
@tecnovert
Add coldstaking xpub works without encrypted wallet.
1e8430f 
Coldstaking status uses only getcoldstakinginfo, reduced poll to 5 seconds.
Display error on revert coldstaking with no stealthaddress.

Check datadir path for .cookie file.
Exit gui works when connecting to running daemon.
@tecnovert
partgui -> particl-desktop
3f48639
@kewde
trigger ci
f246408
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling f246408 on release/1.1.0-RC2 into ** on dev**.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling ee7e4bd on release/1.1.0-RC2 into ** on dev**.

kewde and others added 2 commits January 21, 2018 00:32
@kewde
Patch ipc service, observable now completes. -> should destroy the su…
74f17a3 
…bscription

Fix stakinginfo as example (we must use takeWhile on every _infinite_ observables)
so everytime we use state.observe(..)
@tecnovert
unsubscribe
eaaca27
@coveralls
Copy link

coveralls commented Jan 20, 2018 •
edited

Pull Request Test Coverage Report for Build 3046

  • 73 of 189 (38.62%) changed or added relevant lines in 17 files are covered.
  • 25 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-0.2%) to 45.724%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/app/modals/coldstake/coldstake.component.ts 0 1 0.0%
src/app/modals/syncing/syncing.component.ts 5 6 83.33%
src/app/modals/createwallet/createwallet.component.ts 6 7 85.71%
src/app/core/ipc/ipc.service.ts 0 1 0.0%
src/app/modals/modals.service.ts 4 6 66.67%
src/app/modals/modals.component.ts 4 6 66.67%
src/app/core-ui/main/status/status.component.ts 6 9 66.67%
src/app/core-ui/main/main-view.component.ts 5 10 50.0%
src/app/core/rpc/rpc.service.ts 4 11 36.36%
src/app/wallet/overview/widgets/stakinginfo/stakinginfo.component.ts 6 13 46.15%
Files with Coverage Reduction New Missed Lines %
src/app/wallet/wallet/shared/transaction.service.ts 1 30.5%
src/app/wallet/overview/widgets/stakinginfo/stakinginfo.component.ts 1 49.06%
src/app/core/ipc/ipc.service.ts 1 23.26%
src/app/wallet/overview/widgets/coldstake/revert-coldstaking/revert-coldstaking.component.ts 1 27.78%
src/app/modals/coldstake/coldstake.component.ts 1 36.36%
src/app/modals/createwallet/createwallet.component.ts 1 29.52%
src/app/modals/syncing/syncing.component.ts 1 40.0%
src/app/modals/modals.component.ts 2 71.64%
src/app/core-ui/main/status/status.component.ts 3 45.45%
src/app/wallet/overview/widgets/coldstake/zap-coldstaking/zap-coldstaking.component.ts 5 25.33%
Totals Coverage Status
Change from base Build 3039: -0.2%
Covered Lines: 1671
Relevant Lines: 3040
💛 - Coveralls

kewde and others added 9 commits January 21, 2018 00:46
@kewde
Merge branch 'release/1.1.0-RC2' of https://github.com/particl/partic…
3e66db8 
…l-desktop into release/1.1.0-RC2

Conflicts:
	src/app/wallet/overview/widgets/coldstake/coldstake.component.ts
@kewde
Merge branch 'release/1.1.0-RC2' of https://github.com/particl/partic…
021b364 
…l-desktop into release/1.1.0-RC2

Conflicts:
	src/app/wallet/overview/widgets/coldstake/coldstake.component.ts
@kewde
fix destroy & lint
1a73938
@tecnovert
Catch 'Object has been destroyed' errors.
204b8ca
@tecnovert
TransactionService
dd920f6
@tecnovert
Call wrapped rpc command from next daemon version. Added warning message
1281b73 
to zap and revert dialogs.
@anandsinghparihar
Add takeWhile and destroyed hook in all state.observe call
c4400fc
@kewde
Update main-view.component.ts
5cb2fcf
@pciavald
Merge pull request #738 from particl/state_observer_refactoring
d7343be 
Add takeWhile and OnDestroy hook in all state.observe calls
@pciavald pciavald merged commit 47f64eb into dev Jan 23, 2018
@pciavald pciavald deleted the release/1.1.0-RC2 branch January 23, 2018 12:02
@kewde kewde mentioned this pull request Jan 23, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@kewde @coveralls @rynomster @pciavald @tecnovert @anandsinghparihar