TX confirmation modal 2.0 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*updated AddressHelper utilites *added send information from send component to confirmation component *added variables to html
|
Waiting for #779 to be merged |
kewde
previously approved these changes
Feb 10, 2018
| & > .currency { | ||
| font-size: 17px; | ||
| } | ||
| & > .fiat { |
There was a problem hiding this comment.
Can we hide the fiat div via css rather than comments?
Easier later on & cleaner.
|
When using the Amount class, make sure to initialize the variable with |
fix ringsize bug test things
kewde
reviewed
Mar 18, 2018
| ringsize: number, numsignatures: number, substractfeefromamount: boolean) { | ||
| // @TODO: estimate fee should be change | ||
| public sendTransaction(tx: TransactionBuilder) { | ||
| tx.comment = tx.narration = tx.note; |
anandsinghparihar
force-pushed
the
enhancement/tx-confirm-modal
branch
from
759c029
to
099687f
Compare
|
Hye @kewde @anandsinghparihar when I started the electron for this branch and got this issue (OSX) |
|
On
|
|
@vikas-cis could you please debug that OSX error window ? |
|
@anandsinghparihar yeah I am checking it :) Thanks |
|
#903 log issue has been fix here Thanks |
| @@ -199,6 +199,7 @@ export class SendComponent implements OnInit { | |||
| } | |||
|
|
|||
| dialogRef.componentInstance.dialogContent = txt; | |||
| console.log('>>>>???componentInstance????????>', this.send); | |||
There was a problem hiding this comment.
can you remove the console log @anandsinghparihar
anandsinghparihar
force-pushed
the
enhancement/tx-confirm-modal
branch
from
9749962
to
a4b9a7f
Compare
kewde
approved these changes
Mar 24, 2018
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this PR was based on @pciavald's #724 because I couldn't access the Send tab due to the bug on
dev. If needed, I can rebase ondevwhen fixed.TODO