Add set credentials usb request #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scott-brust
commented
Apr 10, 2024
| * Store network credential but do not attempt to power on wifi or connect. | ||
| * | ||
| * On success, the network credentials get saved to a persistent storage. | ||
| * On failure, there was not enough room to store the credentials |
There was a problem hiding this comment.
This can only happen if DVOS runs out of memory when resizing the 10 item credentials vector. I dont think this is likely to happen?
Do we want to make it explicit that if the device has 10 credentials and we send another one that the 10th credential will be dropped?
Do we want to change this behavior?
There was a problem hiding this comment.
Ideally, we would want to replace SSIDs which are old / least recently connected. But that's probably an overkill? What we can do though is have another control request that loads the config file and then display the SSIDs it in the CLI.
keeramis
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See corresponding dvos PR