[system] Fix bad int to bool conversion for clearCredentials

particle-iot · Feb 9, 2024 · e85e59a · e85e59a
1 parent 1b02456
commit e85e59a
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/system/inc/system_network.h b/system/inc/system_network.h
@@ -102,6 +102,15 @@ typedef WLanCredentials NetworkCredentials;
  * @return 0 on success.
  */
 int network_set_credentials(network_handle_t network, uint32_t flags, NetworkCredentials* creds, void* reserved);
+/**
+ *
+ * @param network   The network to configure the credentials.
+ * @param flags     Flags. set to 0.
+ * @param creds     The credentials to set. Should not be NULL.
+ * @param reserved  For future expansion. Set to NULL.
+ * @return true     Successfully cleared the given network credentials
+ * @return false    Failed to clear the given network credentials
+ */
 bool network_clear_credentials(network_handle_t network, uint32_t flags, NetworkCredentials* creds, void* reserved);
 
 void network_setup(network_handle_t network, uint32_t flags, void* reserved);

diff --git a/system/src/system_network_manager_api.cpp b/system/src/system_network_manager_api.cpp
@@ -438,7 +438,7 @@ bool network_clear_credentials(network_handle_t network, uint32_t, NetworkCreden
     } else {
         if_t iface;
         if (!if_get_by_index(network, &iface)) {
-            return NetworkManager::instance()->clearConfiguration(iface);
+            return NetworkManager::instance()->clearConfiguration(iface) == 0;
         }
     }
     return false;