Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #1055
system_delay_ms
should not use!system_thread_get_state(NULL)
to determine whether to run event loop or not, as it is still possible to create a thread withSYSTEM_THREAD(DISABLED)
and executedelay()
in that thread, which will cause the event loop to be processed from that thread:https://github.com/spark/firmware/compare/feature/delay-event-processing?expand=1#diff-de0a60700cd1e842d6a89faaba614c8cL446
This PR:
system_delay_ms
condition toif ((!PLATFORM_THREADING || APPLICATION_THREAD_CURRENT()) && !HAL_IsISR())
!system_thread_get_state(NULL)
->!PLATFORM_THREADING
APPLICATION_THREAD_CURRENT()
/SYSTEM_THREAD_CURRENT()
macros asapplication_thread_current
/system_thread_current
dynalib functionswiring/threading_no_threading_delay
testDoneness:
BUGFIX