[Electron] Wait for server sent confirmable messages to be acknowledged before sleeping #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed, also wait for server CON requests to be ACKed by the device before sleeping
…n-messages Conflicts: system/inc/system_event.h user/tests/wiring/sleep/sleep.cpp
technobly
approved these changes
Nov 29, 2016
technobly
deleted the
feature/electron/sleep-wait-for-server-con-messages
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1133
Apart from waiting for device generated confirmable messages to be acknowledged, also wait for server sent confirmable requests to be ACKed by the device before sleeping.
Includes PR #1151 for tests.
Relevant tests:
wiring/sleepDoneness:
Bugfixes