Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Electron] Wait for server sent confirmable messages to be acknowledged before sleeping #1158

Merged

Conversation

@avtolstoy
Copy link
Member

commented Nov 6, 2016

Fixes #1133

Apart from waiting for device generated confirmable messages to be acknowledged, also wait for server sent confirmable requests to be ACKed by the device before sleeping.

Includes PR #1151 for tests.

Relevant tests:

  • wiring/sleep

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation (N/A)
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfixes

  • [Electron] Before sleeping, now waits for server sent confirmable messages to be acknowledged, in addition to previous behavior of device generated confirmable messages being acknowledged. Reduces data usage. [Fixes #1133]

@avtolstoy avtolstoy added this to the 0.7.x milestone Nov 7, 2016

Merge branch 'develop' into feature/electron/sleep-wait-for-server-co…
…n-messages

  Conflicts:
	system/inc/system_event.h
	user/tests/wiring/sleep/sleep.cpp

@technobly technobly merged commit 0670525 into develop Nov 29, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/electron/sleep-wait-for-server-con-messages branch Nov 29, 2016

@technobly technobly modified the milestones: 0.7.x, 0.6.1 Nov 29, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.