Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RGB LED mirroring #1204

Merged
merged 10 commits into from Dec 17, 2016

Conversation

@avtolstoy
Copy link
Member

commented Dec 15, 2016

Implements #1113

Wiring functions added:

  • RGB.mirrorTo(pin_t rpin, pin_t gpin, pin_t bpin, bool invert=false, bool bootloader=false)
  • RGB.mirrorDisable(bool bootloader=true)

Relevant tests:

  • wiring/no_fixture: LED_11_MirroringWorks

TODO: Documentation


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Features

  • [PR #1204] [Implements #1113] RGB LED pins can be mirrored to other PWM capable pins via RGB.mirrorTo(). Common Anode/Cathode LED and Bootloader compatible. See PR for usage.

@avtolstoy avtolstoy added this to the 0.6.1 milestone Dec 15, 2016

Merge branch 'develop' into feature/rgb-led-mirror
  Conflicts:
	hal/src/stm32f2xx/hal_dynalib_export.cpp
	modules/photon/system-part2/module_system_part2_export.ld
	modules/photon/system-part2/src/module_system_part2.cpp

@technobly technobly merged commit 273b422 into develop Dec 17, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the feature/rgb-led-mirror branch Dec 17, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.