-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LED signaling fixes #1225
LED signaling fixes #1225
Conversation
@sergeuz adding the docs here in this PR should be fine. |
…tests; minor refactoring
3cca785
to
a65e2cf
Compare
This PR should be ready for merging, once the checks are passed. The docs will go to Electron and Photon are updating their bootloaders as expected and overall seem to work normally in my tests (tested with 0.5.3 and 0.6.1-rc.1 bootloaders). I don't have P1 to make similar test though. |
…1 (v11) is 5.3.1 20160307 Planning to switch all bootloaders, system, user, cloud compiling to GCC 5.3.1 20160307 when 0.7.0-rc.1 is released
…32F2xx.a that saves 388 on P1/Photon
✅ P1 sFlash tests passed. |
This PR introduces the following changes:
LEDStatus
andLEDCustomStatus
into single class (LEDStatus
). I've found it can be somewhat confusing to choose when to use which class, so the less classes the better.SPARK_LED_FADE
flag.@technobly: I'm currently finishing reference docs for the new functionality, should I submit them separately or include into this PR?
Doneness:
Bugfix
Enhancement
LEDStatus
andLEDCustomStatus
into a single class ->LEDStatus
Feature