Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LED signaling fixes #1225

Merged
merged 14 commits into from Jan 13, 2017

Conversation

@sergeuz
Copy link
Member

commented Jan 1, 2017

This PR introduces the following changes:

  • Added support for custom LED colors in bootloader (firmware update, safe mode, DFU mode), v11.
  • Combined LEDStatus and LEDCustomStatus into single class (LEDStatus). I've found it can be somewhat confusing to choose when to use which class, so the less classes the better.
  • Fixed LED indication shown during device key generation (blinking white).
  • Removed obsolete SPARK_LED_FADE flag.
  • Added more unit/API tests.

@technobly: I'm currently finishing reference docs for the new functionality, should I submit them separately or include into this PR?


Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)

Bugfix

  • [PR #1225] [Photon/P1/Electron] Fixed LED indication shown during device key generation (blinking white) introduced in 0.6.1-rc.1

Enhancement

  • [PR #1225] [Photon/P1/Electron] Combined LEDStatus and LEDCustomStatus into a single class -> LEDStatus

Feature

  • [PR #1225] [Photon/P1/Electron] Added support for custom LED colors in bootloader v11 (Safe Mode, DFU Mode, Firmware Reset).

@sergeuz sergeuz added this to the 0.6.1 milestone Jan 1, 2017

@technobly

This comment has been minimized.

Copy link
Member

commented Jan 3, 2017

@sergeuz adding the docs here in this PR should be fine.

@sergeuz sergeuz force-pushed the feature/system_led_fixes branch from 3cca785 to a65e2cf Jan 12, 2017

@sergeuz

This comment has been minimized.

Copy link
Member Author

commented Jan 12, 2017

This PR should be ready for merging, once the checks are passed. The docs will go to docs/prerelease branch in a separate PR.

Electron and Photon are updating their bootloaders as expected and overall seem to work normally in my tests (tested with 0.5.3 and 0.6.1-rc.1 bootloaders). I don't have P1 to make similar test though.

technobly and others added 5 commits Jan 12, 2017
rebuilt photon & electron (v11) bootloader with GCC 4.9.3 20150529, p…
…1 (v11) is 5.3.1 20160307

Planning to switch all bootloaders, system, user, cloud compiling to GCC 5.3.1 20160307 when 0.7.0-rc.1 is released
@technobly

This comment has been minimized.

Copy link
Member

commented Jan 13, 2017

P1 sFlash tests passed.

@technobly technobly merged commit d09c747 into develop Jan 13, 2017

@technobly technobly deleted the feature/system_led_fixes branch Jan 13, 2017

@sergeuz sergeuz referenced this pull request Jan 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.