Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Photon/P1: WiFi.dnsServerIP()/WiFi.dhcpServerIP() support #1386

Merged
merged 4 commits into from Jan 22, 2018

Conversation

Projects
None yet
2 participants
@avtolstoy
Copy link
Member

commented Sep 14, 2017

submission notes
**Important:** Please sanitize/remove any confidential info like usernames, passwords, org names, product names/ids, access tokens, client ids/secrets, or anything else you don't wish to share.

Please Read and Sign the Contributor License Agreement ([Info here](https://github.com/spark/firmware/blob/develop/CONTRIBUTING.md)).

You may also delete this submission notes header if you'd like. Thank you for contributing!

Problem

See #1132

Solution

Implement the support in Photon/P1 wlan_hal.

Steps to Test

  • wiring/no_fixture: WIFI_03_config

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@m-mcgowan m-mcgowan force-pushed the fix/photon-dns-dhcp-ip branch from 665a21d to a8feab5 Jan 18, 2018

@m-mcgowan m-mcgowan added this to the 0.8.0-rc.2 milestone Jan 18, 2018

@m-mcgowan m-mcgowan merged commit 506eb1c into develop Jan 22, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@m-mcgowan m-mcgowan deleted the fix/photon-dns-dhcp-ip branch Jan 22, 2018

@m-mcgowan m-mcgowan added feature enhancement and removed feature labels Feb 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.