Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USB serial number descriptor should report device ID in lower case (0.7.x) #1436

Merged

Conversation

@sergeuz
Copy link
Member

commented Nov 20, 2017

Problem

Fixes #1432.

Note: There's no need to increment the bootloader version, since it has already been done in #1433.

Steps to Test

Ensure that the USB serial descriptor reports the device ID in all lower case in both the regular and DFU device modes.

References

  • [CH9628]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@sergeuz sergeuz added the bug label Nov 20, 2017

@sergeuz sergeuz added this to the 0.7.0 milestone Nov 20, 2017

@sergeuz sergeuz requested a review from m-mcgowan Nov 20, 2017

@m-mcgowan m-mcgowan merged commit e914096 into release/v0.7.0-rc.5 Nov 20, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/usb_descr_device_id_lower_case_0.7.x branch Mar 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.