Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix WiFi credentials clear event not being fired #1580

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
+2 −0
Open

Fix WiFi credentials clear event not being fired #1580

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions system/src/system_network_wifi.h
View file
Open in desktop
Expand Up @@ -184,6 +184,8 @@ class WiFiNetworkInterface : public ManagedIPNetworkInterface<WLanConfig, WiFiNe

bool clear_credentials() override
{
system_notify_event(network_credentials, network_credentials_cleared);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel I would like to make this conditional on the result of wlan_clear_credentials. We should also check if other Radio interfaces need a similar change. It might be better to add it to the network_clear_credentials() function so that it is ubiquitous?


return wlan_clear_credentials() == 0;
}

Expand Down