Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Photon/P1] Fixes 802.11n mode #1755

Merged
merged 1 commit into from Apr 29, 2019

Conversation

@avtolstoy
Copy link
Member

commented Apr 25, 2019

Problem

#1556

Solution

particle-iot/photon-wiced#32

The PR above resolves and incompatibility in WICED code when handling country codes with the current (newer, with KRACK2 security bugfixes) version of CYW43362 firmware we've introduced in #1420, #1419, #1418.

Steps to Test

Attempt to connect to 802.11n-only AP. The connection should succeed.

Example App

N/A

References


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

  • [bug] [Photon/P1] Fixes 802.11n-only mode regression in 0.7.0 ~ 1.1.0-rc.1 #1755

@avtolstoy avtolstoy added the bug label Apr 25, 2019

@avtolstoy avtolstoy added this to the 1.2.0-beta.1 milestone Apr 25, 2019

@avtolstoy avtolstoy requested a review from technobly Apr 25, 2019

@avtolstoy avtolstoy modified the milestones: 1.2.0-beta.1, 1.1.0-rc.2 Apr 25, 2019

@technobly
Copy link
Member

left a comment

Looks good on my Asus RT-N66U router! Tested 1.0.1 would not connect in n-only mode, and then flashed this PR and it connected. The only odd thing is when it connects in n-only mode it doesn't show up on the Client List, but it does the same thing with 0.6.3 firmware.

@avtolstoy avtolstoy merged commit da7cb1f into develop Apr 29, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@avtolstoy avtolstoy deleted the fix/photon-80211n branch Apr 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.