[Gen 3] Fixes mesh pub/sub socket consuming all packet buffers #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@technobly If we are doing 1.3.0-rc.2, sounds like a good idea to put it in there instead of 1.3.1 |
m-mcgowan
reviewed
Jul 23, 2019
| return SYSTEM_ERROR_NO_MEMORY; | ||
| } | ||
|
|
||
| udp_ = std::move(udp); |
There was a problem hiding this comment.
Thanks for clearing up the allocation leak.
wiring/src/spark_wiring_mesh.cpp
Outdated
|
|
||
| // Use atomic exit_ as a simple synchronization primitive to ensure thread-safety | ||
| // instead of a mutex here. | ||
| if (exit_) { |
There was a problem hiding this comment.
there's a race condition here between reading and setting the value - an atomic exchange will avoid this.
Suggested change
| if (exit_) { | |
| if (exit_.exchange(true) { |
avtolstoy
force-pushed
the
fix/gen3-mesh-pubsub-packet-buffers
branch
from
ad11f4e
to
9808280
Compare
m-mcgowan
approved these changes
Jul 26, 2019
avtolstoy
added
ready to merge
…ishes. Cleans up code a bit as well
…eadsDataOutOfPubSubSocket test
…eadsDataOutOfPubSubSocket
avtolstoy
force-pushed
the
fix/gen3-mesh-pubsub-packet-buffers
branch
from
9808280
to
24f4fa0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
See #1828
Solution
This PR mainly simply starts mesh pub/sub thread that reads the data out of the socket even if only
publish()is called.Apart from that it:
MeshPublishclassThreadclass where the thread being started was not given processing time due toos_thread_yieldMESH_01_PublishWithoutSubscribeStillReadsDataOutOfPubSubSockettest.Steps to Test
wiring/no_fixture:MESH_01_PublishWithoutSubscribeStillReadsDataOutOfPubSubSocketExample App
N/A
References
Completeness