Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to ensure device resets after bootloader update #1850

Merged
merged 1 commit into from Jul 10, 2019

Conversation

@technobly
Copy link
Member

commented Jul 10, 2019

This fix needs to also be cherry-picked into develop, but may need some additional changes since this update mechanism wasn't working recently in 1.3.0-rc.1

This PR fixes an issue in PR #1788 that prevents the system from resetting after a bootloader update. Not resetting after the update when the BOOTLOADER_DEPENDENCY has not been met yet means the device will be in SAFE MODE. The device should update the bootloader and boot normally, which this change addresses.

Tested on Photon.

@technobly technobly added this to the 1.2.1 milestone Jul 10, 2019

@technobly technobly requested review from sergeuz and m-mcgowan Jul 10, 2019

@technobly technobly added the bug label Jul 10, 2019

@technobly technobly merged commit 2d10bc6 into release/v1.2.1 Jul 10, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly deleted the fix/bootloader-dfu branch Jul 10, 2019

@technobly technobly referenced this pull request Aug 2, 2019
4 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.