Fix to ensure device resets after bootloader update #1850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix needs to also be cherry-picked into
develop, but may need some additional changes since this update mechanism wasn't working recently in 1.3.0-rc.1This PR fixes an issue in PR #1788 that prevents the system from resetting after a bootloader update. Not resetting after the update when the BOOTLOADER_DEPENDENCY has not been met yet means the device will be in SAFE MODE. The device should update the bootloader and boot normally, which this change addresses.
Tested on Photon.