Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

electron: use standalone DNS client for all modem types #1940

Merged
merged 1 commit into from Oct 15, 2019

Conversation

avtolstoy
Copy link
Member

@avtolstoy avtolstoy commented Oct 11, 2019

Problem

We've seen SARA U2XX modems stuck returning potentially cached DNS lookup results for longer than records' TTL despite the fact that DNS records have been modified. The only thing that caused AT+UDNSRN to correctly re-resolve in those particular cases was to reset the modem.

This causes problems for device service deploys.

Solution

In order to remove this layer of uncertainty with AT+UDNSRN we are using our own DNS client on all Gen 2 cellular devices now, whereas previously we've only used it for LTE SARA R4 devices where AT+UDNSRN was not supported.

Steps to Test

N/A

Example App

N/A

References

  • [CH39529]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

Copy link
Member

@sergeuz sergeuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍 The only suggestion I have is to use the network's DNS address instead of 8.8.8.8 on platforms where we can retrieve that address. It seems unlikely that the network's DNS would treat TTL incorrectly as well (we'll need to test that of course)

@technobly technobly added ready to merge PR has been reviewed and tested and removed needs review labels Oct 11, 2019
@avtolstoy avtolstoy force-pushed the featuer/electron-standalone-dns branch from 9f9518e to 4e26448 Compare October 15, 2019 09:38
@avtolstoy avtolstoy merged commit 60dcc19 into develop Oct 15, 2019
@avtolstoy avtolstoy deleted the featuer/electron-standalone-dns branch October 15, 2019 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ready to merge PR has been reviewed and tested
Projects
None yet
3 participants