OTA adjustments for Argon #2045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Mar 19, 2020
|
|
avtolstoy
added
ready to merge
avtolstoy
force-pushed
the
fix/argon_ota
branch
from
392dc66
to
a56d9d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
This PR introduces the following changes:
Reduce the maximum number of firmware chunks that can be requested by an Argon during OTA from 40 to 20. Argon doesn't seem to be able to receive more than 25 chunks from a given flight of chunks, which causes it to drop
UpdateDonemessages repeatedly.Do not wait for an ACK for a
ChunkMissedmessage synchronously. This causes the comms library to drop packets and blocks the system loop during OTA.Rework logging in the OTA code so that it's easier to debug.
References