Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hal] concurrent: expose full concurrent APIs. #2052

Merged
merged 1 commit into from Mar 22, 2020

Conversation

XuGuohui
Copy link
Member

Expose the rest of concurrent HAL APIs.

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@eberseth
Copy link
Contributor

Please add conditional variable support as well

@avtolstoy avtolstoy added ready to merge PR has been reviewed and tested and removed needs review labels Mar 19, 2020
@avtolstoy avtolstoy added this to the 1.5.0 milestone Mar 19, 2020
@avtolstoy
Copy link
Member

@eberseth Conditional variable implementation is broken. We've previously agreed that we are not going to expose them. If we do require this feature for other work, we should prioritize changing the implementation.

We can always add the support in a separate PR.

@eberseth
Copy link
Contributor

Okay, we'll use an alternate implementation.

@avtolstoy
Copy link
Member

@eberseth Alternate implementation within concurrent HAL or outside of it?

@eberseth
Copy link
Contributor

Perhaps copying out the cv implementation into user space versus using a standard library.

Copy link
Contributor

@eberseth eberseth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed

@XuGuohui XuGuohui merged commit 03f065f into develop Mar 22, 2020
@XuGuohui XuGuohui deleted the feature/concurrent/ch49745 branch March 22, 2020 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ready to merge PR has been reviewed and tested
Projects
None yet
3 participants