Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for unused control requests #2064

Merged
merged 5 commits into from
Mar 31, 2020
Merged

Remove support for unused control requests #2064

merged 5 commits into from
Mar 31, 2020

Conversation

sergeuz
Copy link
Member

@sergeuz sergeuz commented Mar 31, 2020

Problem

We're out of flash space in system-part2 on P1.

Solution

This PR removes the following unused and inconsistently supported functionality available via control requests:

  • Old-style network interface configuration (supported only on Gen 2).
  • Rudimentary support for compressed firmware binaries (supported only on Gen 3).
  • Access to flash memory (supported only on Gen 2).

This frees up about 5K on each platform.

@sergeuz sergeuz added this to the 1.6.0-rc.1 milestone Mar 31, 2020
@sergeuz sergeuz requested a review from avtolstoy March 31, 2020 00:00
avtolstoy
avtolstoy approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@avtolstoy avtolstoy added the ready to merge PR has been reviewed and tested label Mar 31, 2020
@sergeuz sergeuz merged commit b940544 into develop Mar 31, 2020
@sergeuz sergeuz deleted the feature/remove_storage_reqs branch March 31, 2020 16:26
@sergeuz sergeuz mentioned this pull request Jul 10, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
internal ready to merge PR has been reviewed and tested
Projects
None yet
Milestone
1.6.0-rc.1
2 participants
@sergeuz @avtolstoy