-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NTP-based internet test #2118
Merged
Merged
NTP-based internet test #2118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I will start by testing out some tests mentioned on one of my devices. |
e1931de
to
c281414
Compare
sergeuz
approved these changes
Jun 24, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm approving this PR since it does the job. The timestamp calculations don't seem to be correct though.
…after 5 mins, unit tests
…nd selectively increase it for a specific source file
c783717
to
d79f7f1
Compare
sergeuz
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Solution
This PR introduces an SNTP (Simple Network Time Protocol) implementation to be used for internet tests. By default we are targeting
pool.ntp.org
, which allows us to also test DNS and allows us to use the distributed network of NTP servers around the globe in the pool over UDP.We are also changing the logic around when to trigger network interface reset due to cloud connection errors. Previously only "connection" attempts were registered as failures, whereas handshake errors were not taken into account at all. This does work somewhat ok for TCP-based devices (Photon/P1), but these days does not make much sense for connection-less UDP-based devices.
Now, we are taking into account any kind of a cloud connection error and will wait up to 5 minutes of consecutive cloud connection failures across all platforms to trigger a reset of network interfaces.
Steps to Test
Example App
N/A
References
Completeness