Process 'CEREG: 0' URCs on R410M #2119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keeramis
force-pushed
the
ch36648/process_reg_urcs_for_detach
branch
from
23e68b9
to
a279b4a
Compare
keeramis
requested review from
avtolstoy and
technobly
and removed request for
avtolstoy
keeramis
changed the title
keeramis
force-pushed
the
ch36648/process_reg_urcs_for_detach
branch
from
d80bd77
to
dc5b5c2
Compare
keeramis
changed the title
technobly
requested changes
Jun 4, 2020
hal/src/electron/modem/mdm_hal.cpp
Outdated
| @@ -1606,7 +1613,7 @@ bool MDMParser::getCellularGlobalIdentity(CellularGlobalIdentity& cgi_) { | |||
| } | |||
|
|
|||
| void MDMParser::_setBandSelectString(MDM_BandSelect &data, char* bands, int index /*= 0*/) { | |||
| char band[5]; | |||
| char band[6]; | |||
There was a problem hiding this comment.
I'm guessing this band change shouldn't be in this PR?
| _attached = false; | ||
| HAL_NET_notify_disconnected(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Nit: spelling on "Registration"
Should && *reg == REG_NONE be && (*reg != REG_HOME) && (*reg != REG_ROAMING) since that's what we define as REG_OK() .... or simply !REG_OK(*reg)
_attached_urc = (*reg == REG_NONE) ? 0:1; would also not need to be tested, just set to 0, and also then no need to test for if (!_attached_urc).
Perhaps also put the && !strcmp(s, "CEREG:") last, as it will chew up more cycles.
We can also test && reg == &_net.eps instead of strcmp() again?
keeramis
force-pushed
the
ch36648/process_reg_urcs_for_detach
branch
2 times, most recently
from
27fa19d
to
73d305c
Compare
technobly
approved these changes
Jun 4, 2020
keeramis
force-pushed
the
ch36648/process_reg_urcs_for_detach
branch
3 times, most recently
from
abe8cc8
to
7e949e1
Compare
keeramis
force-pushed
the
ch36648/process_reg_urcs_for_detach
branch
from
f2fa171
to
fdd7d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
A registration URC like
CEREG: 0is not processed by Electron LTEs, and hence even though aCEREG: 0is received by the device, the device still blinks cyan assuming it's connected to cloud, and does not attempt a disconnection process.Solution
Read and process reg URCs for
CxREG :0to notify a disconnectionSteps to Test
Example App
After a successful cloud connection, remove antenna or trigger (somehow) a loss of registration, by which you will see a
CEREG: 0on the module. When this happens, notice that the device should go back to blinking green, signaling a new connection attempt.References
ch36648
Completeness