Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement sleep function for I2C peripheral #2129

Merged
merged 11 commits into from Jul 8, 2020
Merged

Implement sleep function for I2C peripheral #2129

merged 11 commits into from Jul 8, 2020

Conversation

YutingYou
Copy link
Contributor

Feature

Implement sleep function for I2C peripheral

Steps to Test

The test case test(I2C_05_Hal_Sleep_API_Test) is added to user/tests/wiring/no_fixture/i2c.cpp

Run the unit test:

make PLATFORM=tracker TEST=wiring/no_fixture MODULAR=y clean all program-dfu

TODO

Formatting changes will be added after the review.

References

[CH55886]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

avtolstoy
avtolstoy requested changes Jun 22, 2020
View reviewed changes
hal/src/nRF52840/i2c_hal.cpp Outdated Show resolved Hide resolved
hal/src/nRF52840/i2c_hal.cpp Outdated Show resolved Hide resolved
hal/src/stm32f2xx/i2c_hal.c Outdated Show resolved Hide resolved
hal/src/nRF52840/i2c_hal.cpp Outdated Show resolved Hide resolved
user/tests/wiring/i2c_master_slave/i2c_master/i2c_master.cpp Outdated Show resolved Hide resolved
@XuGuohui XuGuohui added this to the 2.0.0 milestone Jun 23, 2020
@YutingYou YutingYou force-pushed the feature/sleep_wakeup_i2c/ch55886 branch from 52401da to a21e7e1 Compare June 28, 2020 09:05
avtolstoy
avtolstoy approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@avtolstoy avtolstoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see cleaned up sources!

hal/src/template/i2c_hal.cpp Outdated Show resolved Hide resolved
@XuGuohui XuGuohui added ready to merge PR has been reviewed and tested and removed needs review labels Jul 8, 2020
@XuGuohui XuGuohui force-pushed the feature/sleep_wakeup_i2c/ch55886 branch from 86536b2 to 07d3879 Compare July 8, 2020 13:03
@XuGuohui XuGuohui merged commit 1f9c79e into develop Jul 8, 2020
@XuGuohui XuGuohui deleted the feature/sleep_wakeup_i2c/ch55886 branch July 8, 2020 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuGuohui XuGuohui XuGuohui left review comments

@avtolstoy avtolstoy avtolstoy approved these changes

Assignees
No one assigned
Labels
feature ready to merge PR has been reviewed and tested
Projects
None yet
Milestone
2.0.0
3 participants
@YutingYou @avtolstoy @XuGuohui