Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gen2] rtc: hal_rtc_get_time() is not thread-safe #2154

Merged
merged 1 commit into from
Jul 20, 2020
Merged

[gen2] rtc: hal_rtc_get_time() is not thread-safe #2154

merged 1 commit into from
Jul 20, 2020

Conversation

avtolstoy
Copy link
Member

Problem

As the title says.

Solution

Add an atomic section around RTC time/date fetch calls.

Steps to Test

N/A

Example App

N/A

References

  • [CH42243]

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@avtolstoy avtolstoy added the bug label Jul 20, 2020
@avtolstoy avtolstoy added this to the 2.0.0 milestone Jul 20, 2020
@avtolstoy avtolstoy requested a review from XuGuohui July 20, 2020 08:35
@avtolstoy avtolstoy merged commit ee82be9 into develop Jul 20, 2020
@avtolstoy avtolstoy deleted the fix/gen2-rtc-thread-safety branch July 20, 2020 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XuGuohui XuGuohui XuGuohui approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
2.0.0
2 participants
@avtolstoy @XuGuohui