[system] network diagnostics for Gen 3 platforms #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
force-pushed
the
feature/gen3-network-diag
branch
from
986b726
to
84a9f5b
Compare
sergeuz
approved these changes
Oct 29, 2020
avtolstoy
force-pushed
the
feature/gen3-network-diag
branch
from
a668d95
to
af68546
Compare
avtolstoy
force-pushed
the
feature/gen3-network-diag
branch
from
af68546
to
ede2150
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Network diagnostics/vitals are only enabled on Gen 2 platforms.
Solution
Fix that and enable them for Gen 3 as well.
Steps to Test
Request vitals in the console. They should contain network diagnostics. Make the device disconnect e.g. by unplugging antenna, let it connect again, request vitals.
Example App
N/A
References
Completeness