-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Tracker] ESP32 support #2250
[Tracker] ESP32 support #2250
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(GitHub was stuck while submitting a comment and refreshing a page required to submit a review for some reason)
3b8bb4c
to
cde1dc3
Compare
a192c65
to
37cc890
Compare
@avtolstoy Great reworking, since you've changed the transport layer, I was wondering have you run the stress test for OTA, this would be helpful for the stability of OTA and SDIO. The easiest way may be manually doing updating with CLI several times. Better to upgrade and downgrade. |
@YutingYou Yes, I've done that multiple times, you can see that there are some FIXMEs around XModem that were uncovered both here and in the NCP firmware. I've also listed updates as one of the main things to test :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reminds me that in the system_network_manager.cpp, some of the APIs don't support more than one interface. We need to refactor them but we can do that later if they don't break things.
37cc890
to
c3ef5a9
Compare
c3ef5a9
to
07696b1
Compare
Description
This PR adds WiFi scanning support for Tracker. All other APIs except for WiFi interface state management and scanning are not available as of right now.
This feature branch should work with both the stock 0.0.6 ESP32 NCP firmware available from the factory, as well as with particle-iot/esp32-ncp-firmware#18.
Steps to Test
wiring/no_fixture
tests have been fixed to allow WiFi scanning on Trackerparticle serial inspect
should reflect that)Example App
References
Completeness