Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] v3.0.0-rc.2 #2300

Merged
merged 21 commits into from
Mar 16, 2021
Merged

[Release] v3.0.0-rc.2 #2300

merged 21 commits into from
Mar 16, 2021

Conversation

avtolstoy
Copy link
Member

Review only

sergeuz
sergeuz approved these changes Mar 12, 2021
View reviewed changes
communication/src/messages.cpp Outdated Show resolved Hide resolved
communication/src/messages.cpp Outdated Show resolved Hide resolved
communication/src/publisher.h Outdated Show resolved Hide resolved
hal/network/ncp_client/quectel/quectel_ncp_client.cpp Show resolved Hide resolved
hal/network/ncp_client/quectel/quectel_ncp_client.cpp Show resolved Hide resolved
hal/network/ncp_client/quectel/quectel_ncp_client.cpp Show resolved Hide resolved
hal/network/lwip/cellular/pppncpnetif.cpp Show resolved Hide resolved
@avtolstoy avtolstoy requested a review from sergeuz March 12, 2021 14:25
@avtolstoy
quectel: port ICCID/IMSI retry logic from SARA instead of hard delays…
7fb57d2 
… to speedup warm boot
@avtolstoy
[network] quectel: workaround for resuming into a broken ppp session …
3c564d9 
…on EG91-based devices
@avtolstoy
[test] wiring/no_fixture_long_running: update MTU tests due to added …
2862010 
…support for larger DTLS packets
@avtolstoy
[test] network: minor
97ec42c
@avtolstoy
[network] quectel: enable resume workarounds for BG96 as well
4e5fe7d
@avtolstoy
[network] sara: adjust MTU for devices with R410 fw < 02.03 and adjus…
13cb99d 
…t drop window values
@avtolstoy
[communication] introduce MAX_TRANSMIT_MESSAGE_SIZE connection property
0b8ac76
@avtolstoy
introduce HAL_PLATFORM_BROKEN_MTU feature and enable for Borons and B…
e6e9537 
… SoMs
@avtolstoy
[test] communication: update variable and events tests with lower lim…
6c76400 
…its for Boron and B SoMs with R410 with old fw version
@avtolstoy
[test] minor
9f1a2b5
@avtolstoy
[test] wiring/no_fixture_long_running: minor
e54dde3
@avtolstoy
address review comments
7758ef0
@avtolstoy
[network] ppp: use PAP on Quectel modems
d42cfba
@avtolstoy
[cellular] sara/quectel: make sure that we report a timeout error if …
efc6e01 
…we fail to get IMSI
@avtolstoy
[cellular] make sure we go into full functionality mode before queryi…
df346c0 
…ng ICCID/IMSI
@avtolstoy
[network] quectel: retry CGDCONT a few times as it might be failing t…
b9bb2a5 
…emporarily on cold boot
keeramis
keeramis approved these changes Mar 12, 2021
View reviewed changes
Copy link
Contributor

@keeramis keeramis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested cellular part of the review 👍

@avtolstoy avtolstoy merged commit 802a6eb into develop Mar 16, 2021
@avtolstoy avtolstoy deleted the test/v3.0.0-rc.2 branch March 16, 2021 22:09
@sergeuz sergeuz mentioned this pull request May 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sergeuz sergeuz sergeuz approved these changes

@keeramis keeramis keeramis approved these changes

@technobly technobly Awaiting requested review from technobly

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
3 participants
@avtolstoy @sergeuz @keeramis