[gen3] hal: only skip modules that fail integrity check from module info

[avtolstoy]

Problem

We've introduced a bug in #2374 in the condition used to skip 'invalid' modules from module info. Due to the behavior of fetch_module() it actually returns additional validation flags apart from the ones being requested (in our case only INTEGRITY check is of concern).

Solution

Fix the check to only take into account MODULE_VALIDATION_INTEGRITY and add a comment on the behavior of fetch_module().

Steps to Test

Flash Gen 3 device with Device OS built out of this branch. Update OTA to 3.2.0. The update should succeed. After 3.2.0 application has been flashed, particle serial inspect should report user module with unsatisfied dependencies. On develop, particle serial inspect should not report any user module at all.

Example App

N/A

References

• [gen3] hal: zero out invalid user modules #2374

---

Completeness

• User is totes amazing for contributing!
• Contributor has signed CLA (Info here)
• Problem and Solution clearly stated
• Run unit/integration/application tests on device
• Added documentation
• Added to CHANGELOG.md after merging (add links to docs and issues)