Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/ci-less-frequent-cross-platform-build-checks #2434

Merged

Conversation

busticated
Copy link
Contributor

@busticated busticated commented Apr 15, 2022

Problem

Cross-platform build system CI checks are running more frequently than we'd like or need.

Solution

Only run cross-platform build system CI check against specific branches like:

^main$
^master$
^develop$
^test/v.*
^release/.*

Steps to Test

  1. Create a branch named like release/this-is-a-test
  2. Rebase against this branch and push to remote
  3. Verify that the test-build-system is triggered and runs in CircleCI
  4. Create a branch named test/this-should-not-trigger-workflow
  5. Rebase against this branch and push to remote
  6. Verify that the test-build-system is NOT triggered in CircleCI

(CI Pipeline)

References

https://app.circleci.com/pipelines/github/particle-iot/device-os?filter=all


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@busticated busticated force-pushed the chore/ci-less-frequent-cross-platform-build-checks branch from 5d4746a to 9d67b3d Compare April 15, 2022 00:20
@busticated
Copy link
Contributor Author

FYI here's an example of the workflow being triggered (run 592) and being skipped (run 594):

https://app.circleci.com/pipelines/github/particle-iot/device-os?branch=chore%2Fci-less-frequent-cross-platform-build-checks&filter=all

i tested by adding a "WIP" commit with:

diff --git a/.circleci/config.yml b/.circleci/config.yml
index 68e6055ef..a4b17522f 100644
--- a/.circleci/config.yml
+++ b/.circleci/config.yml
@@ -426,6 +426,9 @@ workflows:
         - matches:
             pattern: "^release/.*"
             value: << pipeline.git.branch >>
+        - matches:
+            pattern: "^chore/.*"
+            value: << pipeline.git.branch >>
     jobs:
       - setup-workspace:
           <<: *tag_filters

...then removing that commit.

@technobly
Copy link
Member

Since all Device OS releases are tested with the following branch naming scheme, could you please add:

        - matches:
            pattern: "^test/v.*"
            value: << pipeline.git.branch >>

@busticated busticated force-pushed the chore/ci-less-frequent-cross-platform-build-checks branch from 9d67b3d to 0e24a88 Compare April 15, 2022 00:44
@busticated busticated marked this pull request as ready for review April 15, 2022 00:44
Copy link
Member

@technobly technobly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@technobly technobly added this to the 3.4.0 milestone Apr 15, 2022
@technobly technobly merged commit 899ed46 into develop Apr 15, 2022
@technobly technobly deleted the chore/ci-less-frequent-cross-platform-build-checks branch April 15, 2022 01:22
@technobly technobly modified the milestones: 3.4.0, 4.0.0 May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants