Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gen3] Device unable to enter listening mode with button press #2451

Merged
merged 1 commit into from
May 13, 2022

Conversation

keeramis
Copy link
Contributor

@keeramis keeramis commented May 13, 2022

Problem

Listening mode cannot be entered through MODE button press with system threading enabled

Solution

ASYNC/SYNC calls related to system threading cannot be performed in HAL ISR. Adjust accordingly.

Steps to Test

Ensure listening mode can be entered through the following ways with system threading enabled and disabled.

  1. User presses SETUP button
  2. Application calls Wiring function to enter listening mode
  3. USB control request to enter listening mode
  4. If there are no credentials in the device

References

SC-102872
#2419


Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@keeramis keeramis added this to the 4.0.0 milestone May 13, 2022
@keeramis keeramis requested a review from avtolstoy May 13, 2022 20:47
@keeramis keeramis merged commit c5d79d9 into develop May 13, 2022
@keeramis keeramis deleted the bugfix/SC-102872 branch May 13, 2022 22:47
@technobly technobly added the bug label May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants