feature/sc-106677/stop-ignoring-device-os-scripts-directory #2471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technobly
approved these changes
Jul 13, 2022
scripts directory now contains p2-related debugging scripts needed to drive Workbench UX
busticated
force-pushed
the
feature/sc-106677/stop-ignoring-device-os-scripts-directory
branch
from
2b0ac27
to
bffadf1
Compare
technobly
deleted the
feature/sc-106677/stop-ignoring-device-os-scripts-directory
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Our developer tools require a series of scripts to support
p2flashing and debugging (e.g.init_km4.gdb). Currently those files live within the./scriptsdirectory and are ignored when creating the toolchain dependency bundleSolution
Stop ignoring the
./scriptsdirectory when building the toolchain bundleSteps to Test
see: https://github.com/particle-iot/cli/pull/44
References
https://app.shortcut.com/particle/story/106677/stop-ignoring-device-os-scripts-directory-when-building-toolchain-bundle
https://github.com/particle-iot/cli#development:~:text=How%20to%20exclude%20files%20and%20directories%20from%20toolchain%20dependency%20bundles
Completeness