Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci][4x] branch pattern changes for test-build-system #2510

Merged
merged 1 commit into from
Aug 15, 2022
Merged

[ci][4x] branch pattern changes for test-build-system #2510

merged 1 commit into from
Aug 15, 2022

Conversation

technobly
Copy link
Member

@technobly technobly commented Aug 15, 2022 •
edited
Loading

Problem

  • If you want to push changes to fix test-build-system, currently you have to modify the branch pattern to do so. There should be some pattern we can use for PRs that allows us to test changes in the PR before they are merged... without having to think about changing the pattern. Suggest anything matching *test-build-system*.
  • Also doesn't include develop-*.x branches

Solution

  • Modify/Add required patterns

Steps to Test

  • CircleCI should run the test-build-system workflow when a branch contains test-build-system
  • CircleCI should run the test-build-system workflow when a branch is merged to develop-4.x

References

sc-107219

Completeness

  • User is totes amazing for contributing!
  • Contributor has signed CLA (Info here)
  • Problem and Solution clearly stated
  • Run unit/integration/application tests on device
  • Added documentation
  • Added to CHANGELOG.md after merging (add links to docs and issues)

@technobly technobly added this to the 4.0.0 milestone Aug 15, 2022
busticated
busticated approved these changes Aug 15, 2022
View reviewed changes
Copy link
Contributor

@busticated busticated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also nice 💪 🙌

@technobly technobly merged commit d340cf7 into develop-4.x Aug 15, 2022
@technobly technobly deleted the chore/test-build-system-4.x branch August 15, 2022 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busticated busticated busticated approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
4.0.0
2 participants
@technobly @busticated