Wait for blockwise requests to complete when connecting to the cloud #2560
+119
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
force-pushed
the
wait_for_blockwise_describe/sc-107101
branch
from
5d41ddb
to
986e832
Compare
…ocessed when a blockwise request is in progress
sergeuz
force-pushed
the
wait_for_blockwise_describe/sc-107101
branch
from
986e832
to
8dea07e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Particle.connected()may returntruewhile the handshake is still in progress if the system/application Describe message is being sent as a blockwise request.Steps to Test
06_register_many_functionsand07_register_many_variablestests no longer fail due to blockwise transfer taking longer to complete.References