-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nRF52: watchdog timeout is not accurate #2635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Mar 9, 2023
avtolstoy
approved these changes
Mar 28, 2023
@@ -178,6 +178,34 @@ test(WATCHDOG_07_notify_2) { | |||
assertEqual(magick, 0xdeadbeef); | |||
} | |||
|
|||
#include "nrf_wdt.h" | |||
test(WATCHDDOG_08_reload_value_is_calculated_correctly) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: I'd generalize this test probably and just move the platform-dependent functionality to get current reload value etc into a separate function.
074355b
to
af9470e
Compare
technobly
pushed a commit
that referenced
this pull request
May 24, 2023
nRF52: watchdog timeout is not accurate
technobly
pushed a commit
that referenced
this pull request
May 26, 2023
nRF52: watchdog timeout is not accurate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
As the title describes. The method of calculating the watchdog reload value may cause the intermediate value overflow, which results in an incorrect reload value being loaded to register.
Solution
Recent nRF5 SDK has fixed this. The PR simply extracts the watchdog related files from the recent SDK and replace the existing files.
Example App
References
https://community.particle.io/t/hardware-watchdog-in-device-os-5-3-0/64031/16
Completeness