[rtl872x] BLE scanning panic #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
reviewed
Apr 19, 2023
hal/src/rtl872x/ble_hal.cpp
Outdated
| @@ -1626,7 +1628,12 @@ int BleGap::startScanning(hal_ble_on_scan_result_cb_t callback, void* context) { | |||
| } | |||
| HAL_Delay_Milliseconds(10); | |||
| } | |||
| SPARK_ASSERT(!isScanning_); | |||
| if (isScanning_) { | |||
| stop(); | |||
There was a problem hiding this comment.
What if it's deadlocked etc? Should we check return values here and SPARK_ASSERT if it fails to reinitialize perhaps?
avtolstoy
approved these changes
Apr 24, 2023
XuGuohui
force-pushed
the
fix/rtl872x_ble_scan/sc117514
branch
from
a858d4c
to
5bf3091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
BLE scanning may finally panic after running for a long time, bacause of corrupted BLE stack.
Solution
Restart BLE stack, instead of panic.
Steps to Test
user/tests/app/ble/scanneroruser/tests/app/ble/uart_centralReferences
N/A
Completeness