Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/nanopb string max size #2657

Merged
merged 3 commits into from Jun 1, 2023
Merged

Fix/nanopb string max size #2657

merged 3 commits into from Jun 1, 2023

Conversation

avtolstoy
Copy link
Member

Includes a bugfix for one more issue I found in spark_wiring_string.

@avtolstoy avtolstoy added this to the 5.4.0 milestone Jun 1, 2023
@avtolstoy avtolstoy requested a review from technobly June 1, 2023 17:42
technobly
technobly approved these changes Jun 1, 2023
View reviewed changes
Copy link
Member

@technobly technobly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Tested with Argon on 5.3.2 vs. this PR on Particle iOS app with Wi-Fi setup.

@avtolstoy avtolstoy merged commit e551dd3 into develop Jun 1, 2023
1 check passed
@avtolstoy avtolstoy deleted the fix/nanopb-string-max-size branch June 1, 2023 23:51
@scott-brust scott-brust mentioned this pull request Jun 13, 2023
Merged
@eberseth eberseth added the 4.x label Aug 9, 2023
@technobly technobly mentioned this pull request Sep 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@technobly technobly technobly approved these changes

Assignees
No one assigned
Labels
4.x
Projects
None yet
Milestone
5.4.0
3 participants
@avtolstoy @technobly @eberseth