[rtl872x] usb: HID #2659
Merged
[rtl872x] usb: HID #2659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuGuohui
reviewed
Jun 6, 2023
| } else { | ||
| return handleOutSetupRequest(req); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Nit: we can remove the else here, the above if will always return directly.
| return dev_->setupReply(req, nullptr, 0); | ||
| } | ||
| break; | ||
| } |
There was a problem hiding this comment.
Nit: To be consistent, add default case. The following switch does add default.
| } | ||
|
|
||
| int HidClassDriver::setup(SetupRequest* req) { | ||
| if (req->bmRequestTypeType != SetupRequest::TYPE_CLASS && req->bmRequestTypeType != SetupRequest::TYPE_STANDARD) { |
There was a problem hiding this comment.
Nit: prefer to use CHECK(). Same to other checks.
| 0xc0 // END_COLLECTION | ||
| }; | ||
|
|
||
| const size_t DEFAULT_HID_DESCRIPTOR_DIGITIZER_LEN = 65; |
| @@ -34,6 +34,7 @@ using namespace particle::usbd; | |||
| namespace { | |||
|
|
|||
| const char DEFAULT_NAME[] = HAL_PLATFORM_USB_PRODUCT_STRING " " "USB Serial"; | |||
| const uint8_t DUMMY_IN_EP = 0x8a; | |||
XuGuohui
approved these changes
Jun 6, 2023
XuGuohui
approved these changes
Jun 6, 2023
eberseth
approved these changes
Jun 6, 2023
avtolstoy
force-pushed
the
feature/p2-usb-hid
branch
from
07fe1a9
to
6f19fb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
USB HID (Mouse / Keyboard) support for P2 / Photon 2.
Same APIs as previously on Photon / P1 / Electron:
https://docs.particle.io/reference/device-os/api/keyboard/keyboard/
https://docs.particle.io/reference/device-os/api/mouse/mouse/
Caveats
Mouse.moveTo()might not be moving the cursor (at least on Linux). Might need to come up with a different digitizer descriptor. Wayland uses multiple pointers, so standard pointer doesn't move. Might be the same nowadays on Windows/OSX.