[rtl872x] linker: stop relying on .dynalib + .psram_text being contiguous and properly and similarly aligned within LMA and VMA, just copy them separately #2665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uous and properly and similarly aligned within LMA and VMA, just copy the separately
scott-brust
approved these changes
Jun 21, 2023
| @@ -50,6 +55,12 @@ __attribute__((section(".xip.text"))) void* module_user_pre_init() { | |||
| // Initialize .bss | |||
| _memset(&link_bss_location, 0, link_bss_size ); | |||
|
|
|||
| // Copy .dynalib | |||
| if ( (&link_dynalib_start != &link_dynalib_flash_start) && (link_dynalib_size != 0)) | |||
There was a problem hiding this comment.
&link_dynalib_start and &link_dynalib_flash_start will always be different right? One is the the VMA in PSRAM and the other is the LMA from flash?
Is this comparison check just a holdover from the past, or if the sections happen to be the same VMA+LMA and no copying is needed?
There was a problem hiding this comment.
They should be yes, just a precaution if they are the same (no LMA).
XuGuohui
approved these changes
Jun 22, 2023
|
@XuGuohui 🤷 Most likely because the libs used in the attached application have some special internal alignment requirements, this makes linker lay out things in a different way to what we normally see, causing a difference between LMA and VMA layout. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some user apps break expectations of
.dynalib+.psram_textbeing contiguous and similarly aligned in LMA (flash) and VMA (PSRAM).Solution
We've had a number of issues with LD over the years especially during compiler version upgrades, so instead of relying on a workaround that exists in system-part1 right now, simply copy
.dynaliband.psram_textseparately.Steps to Test
Build system-part1 and the app below, both should run correctly.
You_re_Muted__inferencing.zip
Example App
N/A
References
N/A
Completeness