[rtl872x] Add MSoM platform support #2681
Conversation
| HAL_USART_SERIAL4 = 3, | ||
| HAL_USART_SERIAL5 = 4, | ||
| HAL_USART_SERIAL1 = 0, // maps to Serial1 | ||
| HAL_USART_SERIAL2 = 1, // may map to NCP or Serial2, see HAL_PLATFORM_CELLULAR_SERIAL / HAL_PLATFORM_WIFI_SERIAL |
There was a problem hiding this comment.
All of these comments are identical. Is this intended?
There was a problem hiding this comment.
These were added when we reordered the USART serial definitions, ill let @technobly comment
| #define HAL_PLATFORM_POWER_MANAGEMENT_OPTIONAL (1) | ||
|
|
||
| #define HAL_PLATFORM_RADIO_ANTENNA_INTERNAL (0) | ||
| #define HAL_PLATFORM_RADIO_ANTENNA_EXTERNAL (0) |
There was a problem hiding this comment.
Does this need to be set to '1'?
There was a problem hiding this comment.
(I posted this comment previously but it got deleted somehow)
Its a good question. I think HAL_PLATFORM_RADIO_ANTENNA_EXTERNAL is intended for platforms that have both an internal and external wifi / ble antenna ( ie P2, Argon, etc). This define allows selectAntenna() to control the IO needed to switch between an external and internal antenna for BLE/WIFI.
MSoM does not appear to have a switch, so in effect it only has the external BLE/WIFI antenna. So it just always defaults to that and calling
selectAntenna()
will return
SYSTEM_ERROR_NOT_SUPPORTED
So I dont think we need to enable these options.
There was a problem hiding this comment.
As long as SYSTEM_ERROR_NOT_SUPPORTED is returned and getAntenna() returns the external one then we can pass over this setting.
| hal_usart_end(HAL_USART_SERIAL2); | ||
| hal_usart_begin_config(HAL_USART_SERIAL2, 57600, SERIAL_8N1, nullptr); | ||
| #endif | ||
| #if HAL_PLATFORM_CELLULAR |
There was a problem hiding this comment.
I dont believe so. HAL_PLATFORM_CELLULAR is intended to pair with HAL_PLATFORM_CELLULAR_SERIAL below. IE if platform cellular is defined, then there should be a serial interface for that cellular defined as well.
| hal_usart_end(HAL_USART_SERIAL2); | ||
| hal_usart_begin_config(HAL_USART_SERIAL2, 57600, SERIAL_8N1, nullptr); | ||
| #endif | ||
| #if HAL_PLATFORM_CELLULAR |
There was a problem hiding this comment.
I dont believe so. HAL_PLATFORM_CELLULAR is intended to pair with HAL_PLATFORM_CELLULAR_SERIAL below. IE if platform cellular is defined, then there should be a serial interface for that cellular defined as well.
…rdware. If there is no power config in DCT, make sure HAL_POWER_PMIC_DETECTION is still set
scott-brust
force-pushed
the
feature/add-msom-platform
branch
from
001ce62
to
295ad19
Compare
| @@ -1379,6 +1379,7 @@ int QuectelNcpClient::registerNet() { | |||
| CHECK_TRUE(r == 1, SYSTEM_ERROR_UNKNOWN); | |||
| r = CHECK_PARSER(respNwMode.readResult()); | |||
| CHECK_TRUE(r == AtResponse::OK, SYSTEM_ERROR_UNKNOWN); | |||
| #if PLATFORM_ID == PLATFORM_MSOM | |||
There was a problem hiding this comment.
If we do want to enable 2G fallback on Tracker, we have enough space for 5.5.0. Just not in develop for now.
Problem
Support for MSoM hardware platform
Solution
Updated to support DVT pinmap, various other fixes
Steps to Test
Example App
References
Completeness