[rtl872x] remove the delay in UART flush() #2686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avtolstoy
approved these changes
Aug 16, 2023
technobly
force-pushed
the
fix/rtl872x_uart_flush
branch
from
849a89b
to
ef331cd
Compare
technobly
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The delay in UART
flush()may cause user app fail to synchronize with the peer UART device.The delay actinng as a hacky workaround was introduced in this PR2586: #2586 and may be potentially fixed by another PR2581: #2581
Solution
Remove the delay.
Steps to Test
Re-run the test app that is shown in the PR2586 and it turned out to be working fine after removing the delay, i.e. device can enter sleep as expected and it doesn't leak power in sleep mode.
References
N/A
Completeness