ACM MVP Behavior changes #2738
ACM MVP Behavior changes #2738
Conversation
|
|
||
| if (spark_cloud_flag_connected() && disconnectCloud) { | ||
| auto systemOptions = options.toSystemOptions(); | ||
| spark_cloud_disconnect(&systemOptions, nullptr); |
There was a problem hiding this comment.
Should we defer the actual disabling of the SPARK_CLOUD_AUTO_CONNECT flag to the system task queue? I'm worried we would get into a situation where the cloud reconnect options would be consumed/overridden before cloud_disconnect() runs and re-sets the cloud auto connect flag...
| // If cloud is already connected, and a preferred network is set, and it is up, move cloud connection to it immediately | ||
| if (spark_cloud_flag_connected() && network_ready(spark::Network.from(preferredNetwork_), 0, nullptr)) { | ||
| auto options = CloudDisconnectOptions().graceful(true).reconnect(true).toSystemOptions(); | ||
| spark_cloud_disconnect(&options, nullptr); |
There was a problem hiding this comment.
Same concern here about executing this on the system task as from network manager context
|
[sc-125332] |
| @@ -609,11 +616,25 @@ void NetworkManager::handleIfLink(if_t iface, const struct if_event* ev) { | |||
| } else if (state_ == State::IP_CONFIGURED || state_ == State::IFACE_LINK_UP) { | |||
| refreshIpState(); | |||
| } | |||
|
|
|||
| // If the preferred network becomes available, close the cloud connection to force migration to this network | |||
| if (ConnectionManager::instance()->getPreferredNetwork() == netIfIndex) { | |||
There was a problem hiding this comment.
This works, but technically is not the correct spot to check if a network is ready (ie IP configured).
This state is just link up. The implicit assumption here is that the interface will be assigned an IP by the time we try to reopen the cloud socket, which usually is true.
I think to be strictly correct, the transition from link up -> ip configured is detected in refreshIpState(), so perhaps we should check for connection migration there?
scott-brust
force-pushed
the
acm-failover-speed
branch
from
ca96bf6
to
3961b46
Compare
scott-brust
force-pushed
the
acm-failover-speed
branch
from
3961b46
to
d1ab306
Compare
|
[sc-125333] |
…ct particle cloud and reconnect on next available network
…ed interface when set and when it becomes available
…grate to a preferred network
scott-brust
force-pushed
the
acm-failover-speed
branch
from
d1ab306
to
13bec90
Compare
Problem
Changes in ACM behavior as discussed internally, and as in this epic
Solution
-Remove ability to bind cloud connection to specific networks interfaces
-Disconnect cloud connection if the network interface reports link down in order to "fail over" faster
-Implement Hard preference for cloud connection.
Steps to Test
Run connection-manager app
Example App
Run connection-manager app