-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish last reset event on session resumption #2771
Closed
monkbroc
wants to merge
30
commits into
develop
from
feature/sc-128022/publish-last-reset-event-on-session-resumption
Closed
Publish last reset event on session resumption #2771
monkbroc
wants to merge
30
commits into
develop
from
feature/sc-128022/publish-last-reset-event-on-session-resumption
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When the device reboots and resumes its session (for example after
System.reset()
and after pin reset on Gen 3), thespark/device/last_reset
event is not published. It's only published when a new session is established.Solution
Publish last reset reason whenever the first cloud connection is established, regardless if it's a new session or a resumed session.
Note: there's a lot of duplication in
if (!session_resumed)
part ofSpark_Handshake
and it's not clear if additional things in theif
should also be done in theelse
. Please think about this as part of the review for this PR.Steps to Test
Ensure a
spark/device/last_reset
is published in the following conditionsparticle usb reset
Example App
When device resets from
System.reset()
,spark/device/last_reset
with datauser
should be published.References
https://app.shortcut.com/particle/story/128022/publish-last-reset-event-on-session-resumption
Completeness