Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash during wifi scan due to reading invalid RAM #910

Merged
merged 2 commits into from Mar 18, 2016

Conversation

monkbroc
Copy link
Member

Update WICED so that marginal scans of WPA protected networks don't lead to a crash.

Fixes #651

@m-mcgowan do you prefer rebuilding WICED yourself? This is the only library that changed, but the other ones rebuilt with a few bytes different (different compiler version, build date and paths probably).

Update WICED so that marginal scans of WPA protected networks don't lead to a crash.

Fixes #651
@m-mcgowan
Copy link
Contributor

Hey @monkbroc! While surveying the code, I noticed we don't yet have any tests in wiring/no_fixture for WiFi.scan(). Please add a generic test that simply runs WiFi.scan() as a smoke test. (If the returned values can be validated, such as valid SSID name/length, BSSID etc.. that is nice, but not essential.) Let @sergeuz know when this is done so he can independently compile and run the tests.

@monkbroc
Copy link
Member Author

I added a WiFi.scan() smoke test. It just checks if there is 1 or more AP found. I can't think of a better validation.

@sergeuz could you please compile this branch and run the wiring/no_fixture tests?

@sergeuz
Copy link
Member

sergeuz commented Mar 18, 2016

@monkbroc The test works for me

@m-mcgowan m-mcgowan added this to the 0.5.x milestone Mar 18, 2016
monkbroc added a commit that referenced this pull request Mar 18, 2016
Avoid crash during wifi scan due to reading invalid RAM
@monkbroc monkbroc merged commit 9a99ba6 into develop Mar 18, 2016
@monkbroc monkbroc deleted the feature/safe-scan-wpa-ie branch March 23, 2016 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants