Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USART configuration fixes #997

Merged
merged 10 commits into from Jun 10, 2016

Conversation

@avtolstoy
Copy link
Member

commented May 8, 2016

The PR is created on top of #930 (LIN Bus support, USART hardware flow control configuration support)

  • Cleaned up USART settings
  • Adds support for 7E1, 7E2, 7O1, 7O2 modes
  • Fixes 9-bit receiving. Issue #968
  • Extra bits are masked out when receiving/transmitting data
  • Extend tests to verify correct transmission

Doneness:

  • Contributor has signed CLA
  • Problem and Solution clearly stated
  • Code peer reviewed
  • API tests compiled
  • Run unit/integration/application tests on device
  • Add documentation
  • Add to CHANGELOG.md after merging (add links to docs and issues)
@technobly

This comment has been minimized.

Copy link
Member

commented May 9, 2016

Very nice! Do you want to add docs to this PR? Looks like a lot of new config values to document.

@monkbroc

This comment has been minimized.

Copy link
Member

commented May 12, 2016

Speaking of docs, the firmware.md file you modified is not the most current one in the docs and the serial section has changed a bit https://github.com/spark/docs/blob/663c8f852c4e08344851f7f20d2fbc8f362ce398/firmware/firmware.md

Can you shed some light @m-mcgowan on how @avtolstoy can update firmware.md in the firmware repo so he's modifying the latest version from the docs?

@m-mcgowan m-mcgowan added this to the 0.6.x milestone Jun 8, 2016

@technobly technobly force-pushed the feature/serial-config branch from 5bec6b6 to 888f99e Jun 10, 2016

@technobly

This comment has been minimized.

Copy link
Member

commented Jun 10, 2016

  • rebased against develop and force pushed to feature/serial-config

@technobly technobly merged commit 62f1327 into develop Jun 10, 2016

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@technobly technobly removed their assignment Jun 10, 2016

@technobly technobly deleted the feature/serial-config branch Oct 27, 2016

technobly added a commit that referenced this pull request Dec 22, 2016
technobly added a commit that referenced this pull request Dec 22, 2016
Squashed 'docs/reference/' changes from e5391c4..a892020
a892020 unifying Since x.x.x firmware version messages
b153672 Since 0.7.0 -> Since 0.6.1
52a6313 Merge commit '60e0e09d54c2b5c1ebe875861da77a306d3c785b' into prerelease-dup
9dac290 More typos fixed
5295a53 corrected grammar (#524)
9f4b24b Spell check docs
fcca5c6 occaisonal --> occasional
60e0e09 Reference documentation
ef0dad7 Merge pull request #1190 from spark/feature/setup-button-mirror
d2eb670 Merge pull request #1195 from spark/fix/revert_publish_api
05d0200 Merge branch 'develop' into feature/listen-timeout
2b43c71 grammatical error
878ba19 Revert Particle.publish() API changes; docs for WITH_ACK flag
b7030c5 Update firmware.md
d84a942 Add advanced process control
fa03d96 Fix broken link on firmware page
03b8a78 Document Process::run
08047a0 EEPROM is borken on RPi
566a869 buttonMirror() documentation
ea100c7 Support for `Serial1` is not complete
468b33d Raspberry Pi I2C firmware docs
32e5ba4 Remove software timers from RPi docs.
26d7251 Merge branch 'develop' into feature/conn_state_events
e15b410 added v0.6.0 firmware notes
38614db adds Docs for set|getListenTimeout()
9949e2d adds usb-serial1 device tags
eee29b2 cleanup serial2 and manual edits from last merge with conflicts
616330f Merge branch 'master' into prerelease
4590339 Update firmware docs to use device features
8e1149f Add device feature flags
62312f0 Add Raspberry Pi to firmware, tools and guides
7168402 Update firmware.md
c93d248 Clarification of retained SRAM size
73f2e00 corrected typo 'sequencially' to 'sequentially'
648234c Merge pull request #468 from spark/feature/usb-docs-0.6.0
d3e5eba Reference docs
7794203 Merge branch 'master' into prerelease
edcf989 adds link to freertos4core particle library
1ffdd80 time_changed system event
dbc5d03 Time.isValid(), Particle.syncTimeDone()/syncTimePending()/timeSyncedLast() documentation
c380dfd [optional] needs to include the optional comma too
6f5c96d Merge branch 'master' into prerelease
6cf14d1 Update firmware.md
6e6e216 Merge branch 'master' into prerelease
f2cf630 adding notes for 0.5.1 and 0.5.2 firmware versions
6249120 adds reference.hbs back to firmware.md
6fa5464 ensure firmwareversions.js only loads on firmware.md aka firmware reference
4fc16b8 added CLI version, electron part 2/3 options and downgrading instructions
ad530eb Separate Firmware Release and Formatting Tweaks
aafbabe Create possibility for passing variables thorugh query params, for Firmware Releases
25cab35 Fixes typo
1aa4c18 Add B0-B5, C0-C5 to GPIO list in note for electron
c857e8a Merge branch 'master' into prerelease
dac4690 Keyboard and Mouse documentation
8d974bf Updated Serial documentation
fd24a4d Merge pull request #467 from dougalcampbell/patch-1
4d75a59 Missing doc for TCPClient(buffer, len)
1b667e5 Use `hostname` instead of `URL` terminology
d0e5903 Merge commit '568ceade3e1481cdb00dcdf51a97a737750a96bb' from firmware-docs into staging
d49ac39 Merge branch 'master' into feature/tutorials
e205803 Makes tests pass, fixing broken dashboard links
66a1955 Fix your product id link
81f7eb6 More Dashboard -> Console
266e459 fixed: markdown for threading docs
4f615c9 missing markdown for interrupts example
568cead Daylight Saving Time (DST) documentation
a696d8a new analogRead() pinMode behavior for 0.5.3 system firmware
aa2994a Fix description of sleep(pin, edge)
5c049dc fix typos
b69e421 Typo in SoftAP example
be62c64 Clarify behavior of 0 seconds in System.sleep() (#425)
838d6c7 missing parameters for printlnf()
7503310 relocated note
62acc8d missed # in condition 😊
f50a589 Update firmware.md
7bc380b Note WKP for deep sleep
af77e5e Merge branch 'feature/reset-network-flag' into develop
405e9e9 Documentation fixes
0415ab4 API docs
0e0a691 Minor fixes
53f993b API docs for logging attributes
18483a2 Merge pull request #991 from spark/feature/dac-pwm-resolution
747f8d0 Merge pull request #997 from spark/feature/serial-config
26eaba8 Merge pull request #998 from spark/feature/logger_api
b7f3081 Update flush() documentation
af32b6b Store last reset reason and publish it to the cloud (#944)
08d2d42 USART configuration documentation
20ebf60 API docs
29e91a1 reduce datausage on reset/wakeup (#953)
6665b03 typo
4caa81c One carriage return isn't enough to make a new paragraph (#414)
a4f05d6 Fix typo in handlebar if
c790bcb Take out factory reset for anything but the Core
d41c053 WIFI_CONNECT_NO_LISTEN actually is WIFI_CONNECT_SKIP_LISTEN
4db5752 Increase documented number of cloud functions and variables (#397)
80ff0e9 Add PRODUCT_ID to the firmware docs
dc99c6e Reword cloud function #389
66f4acf analogWriteResolution documentation
3602095 Fix layout in Serial.begin()
df96c32 Clarify include header for Serial2
761f7c4 explicitly show the particle.function protype
6667d16 add a single letter, whenver->whenever
79ea057 Wire.stretchClock() feature enabled by default for I2C Slave mode
f3ad8b5 made firmware.md a symlnk on linux...didn't take on OS X

git-subtree-dir: docs/reference
git-subtree-split: a892020dc28f10d348c813f63e77099993ecf5f6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.