Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Block APIs #157

Merged
merged 6 commits into from May 12, 2023
Merged

Implement Block APIs #157

merged 6 commits into from May 12, 2023

Conversation

laupow
Copy link
Contributor

@laupow laupow commented May 4, 2023

Story details: https://app.shortcut.com/particle/story/118188

Note: httpbin.org is used for some tests in this project. That service is increasingly slow/unreliable. I added some retries and longer timeouts. If the flakiness persists, we should refactor further.

laupow added 4 commits May 3, 2023 16:04
Wait up to 30 seconds for integration test
httpbin is not very fast
@laupow laupow force-pushed the feature/sc-118188/implement-block-apis branch from ffe862b to ef42529 Compare May 8, 2023 19:17
Copy link
Contributor

@cole-abbeduto-particle cole-abbeduto-particle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the type fix, lgtm!

@laupow laupow merged commit 1e37197 into master May 12, 2023
3 checks passed
@laupow laupow deleted the feature/sc-118188/implement-block-apis branch May 12, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants