feature/sc-121448/configure-typescript-with-just-checkjs #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosHdez
force-pushed
the
feature/sc-121449/use-fetch-in-agent-js
branch
from
1937c94
to
cf2b7bc
Compare
monkbroc
force-pushed
the
feature/sc-121449/use-fetch-in-agent-js
branch
from
d41e0ec
to
a29b473
Compare
Base automatically changed from
feature/sc-121449/use-fetch-in-agent-js
to
master
September 8, 2023 21:36
CarlosHdez
force-pushed
the
feature/sc-121448/configure-typescript-with-just-checkjs
branch
from
32c7861
to
1b939e4
Compare
monkbroc
reviewed
Sep 12, 2023
| @@ -75,7 +83,9 @@ class Particle { | |||
| username, | |||
| password, | |||
| grant_type: 'password', | |||
| // @ts-ignore | |||
There was a problem hiding this comment.
I'm curious why these ts-ignore are necessary
There was a problem hiding this comment.
The ones related to this are because they are set by doing Object.assign(this, Defaults, options); but they have no explicit this.clientId initialization so it was complaining of this not having said properties.
I thought of adding default values before the object.assign but wasn't sure which values to give it
CarlosHdez
deleted the
feature/sc-121448/configure-typescript-with-just-checkjs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds typescript configurations to run
checkJSand fixes docs errors