timeouts #63
Closed
timeouts #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-mcgowan
force-pushed
the
feature/timeouts
branch
from
7c96ab1
to
84519f3
Compare
monkbroc
reviewed
May 24, 2017
| @@ -2,5 +2,6 @@ export default { | |||
| baseUrl: 'https://api.particle.io', | |||
| clientSecret: 'particle-api', | |||
| clientId: 'particle-api', | |||
| tokenDuration: 7776000 // 90 days | |||
| tokenDuration: 7776000, // 90 days | |||
| timeout: 60000 | |||
There was a problem hiding this comment.
Is this value going to be used anywhere? It sets particle.timeout = 60000 but this.timeout is not used in the Particle class. If it's unused let's remove this line.
| @@ -137,6 +145,9 @@ export default class Agent { | |||
| if (query) { | |||
| req.query(query); | |||
| } | |||
| if (timeout!==undefined) { | |||
| req.timeout(timeout); | |||
There was a problem hiding this comment.
What is the user-facing behavior of a timeout? This is an public interface change. An opt-in one but a change nevertheless. How would a user program deal with a timeout vs an HTTP error?
| @@ -137,6 +145,9 @@ export default class Agent { | |||
| if (query) { | |||
| req.query(query); | |||
| } | |||
| if (timeout!==undefined) { | |||
| req.timeout(timeout); | |||
There was a problem hiding this comment.
What is the user-facing behavior of a timeout? Adding a timeout is a public interface change since it will affect the promise rejection. We need to document what will happen when there's a timeout compared to an HTTP error. This is more of a documentation comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds timeouts based on #20, with unit tests
[CH4422]