Catch event handler error #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
busticated
reviewed
Jul 2, 2018
src/EventStream.js
Outdated
| if (this.eventName !== 'event') { | ||
| this.emit(this.eventName, event); | ||
| } | ||
| this.emit('event', event); |
There was a problem hiding this comment.
i realize this isn't a change you introduced but i'm wondering why the if statement here is needed at all?
e.g. simply:
this.emit(this.eventName, event);
There was a problem hiding this comment.
Because this would emit the Node event twice if the Particle event was name event. It's a bad pattern to emit a Node event from the Particle event name. The Particle event error also clashes with the Node error event.
monkbroc
force-pushed
the
feature/catch-event-handler-error
branch
from
a36b356
to
e0eb866
Compare
busticated
approved these changes
Jul 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSE stream parser does not handle errors well. If a user event handler throws an exception, the error will be silently ignored and the parser will stop parsing future events. Parsing errors in the JSON data will also be silently ignored and the parser will stop parsing future events.
TODO: there parser has no tests. We should add
EventStream.spec.jsto test the implementation.Fixes #15 and fixes #62