WIP

src/cli/variable.js

@@ -17,7 +17,11 @@ module.exports = ({ commandProcessor, root }) => {
 
 	commandProcessor.createCommand(variable, 'get', 'Retrieve a value from your device', {
 		params: '[device] [variableName]',
-		options: timeOption,
+		options: Object.assign({}, timeOption, {
+			'product': {
+				description: 'product id or slug'
+			}
+		}),
 		handler: (args) => {
 			const VariableCommand = require('../cmd/variable');
 			return new VariableCommand().getValue(args);

src/cli/variable.test.js

@@ -88,6 +88,7 @@ describe('Variable Command-Line Interface', () => {
 					'',
 					'Options:',
 					'  --time     Show the time when the variable was received  [boolean]',
+					'  --product  product id or slug  [string]',
 					'',
 					'Examples:',
 					'  particle variable get basement temperature  Read the temperature variable from the device basement',

src/cmd/api.js

@@ -102,6 +102,17 @@ module.exports = class ParticleApi {
 		return this._wrap(this.api.compileCode({ files, platformId, targetVersion, auth: this.accessToken }));
 	}
 
+	getVariable(deviceId, name, product){
+		return this._wrap(
+			this.api.getVariable({
+				name,
+				deviceId,
+				product,
+				auth: this.accessToken
+			})
+		);
+	}
+
 	downloadFirmwareBinary(binaryId, downloadPath){
 		return new Promise((resolve, reject) => {
 			const req = this.api.downloadFirmwareBinary({ binaryId, auth: this.accessToken });

src/cmd/variable.js

@@ -1,3 +1,4 @@
+const os = require('os');
 const VError = require('verror');
 const moment = require('moment');
 const has = require('lodash/has');
@@ -6,8 +7,10 @@ const find = require('lodash/find');
 const filter = require('lodash/filter');
 const prompt = require('inquirer').prompt;
 const settings = require('../../settings');
+const { errors: { usageError } } = require('../app/command-processor');
 const spinnerMixin = require('../lib/spinner-mixin');
 const LegacyApiClient = require('../lib/api-client');
+const ParticleAPI = require('./api');
 const UI = require('../lib/ui');
 
 const { normalizedApiError } = LegacyApiClient;
@@ -34,7 +37,32 @@ module.exports = class VariableCommand {
 			});
 	}
 
-	getValue({ time, params: { device, variableName } }){
+	getValue({ time, product, params: { device, variableName } }){
+		if (product){
+			if (!device){
+				throw usageError(
+					'`device` parameter is required when `--product` flag is set'
+				);
+			}
+
+			if (!variableName){
+				throw usageError(
+					`\`variableName\` parameter is required when \`--product\` flag is set. To view available variables, run: particle product device list ${product}`
+				);
+			}
+
+			const msg = `Fetching variable ${variableName} from device ${device} in product ${product}`;
+			const fetchVar = createAPI().getVariable(device, variableName, product);
+			return this.showBusySpinnerUntilResolved(msg, fetchVar)
+				.then(res => {
+					this.ui.stdout.write(`${res.result}${os.EOL}`);
+				})
+				.catch(error => {
+					const message = `Error fetching variable: \`${variableName}\``;
+					throw createAPIErrorResult({ error, message });
+				});
+		}
+
 		return Promise.resolve()
 			.then(() => {
 				if (!device && !variableName){
@@ -233,3 +261,17 @@ module.exports = class VariableCommand {
 	}
 };
 
+
+// UTILS //////////////////////////////////////////////////////////////////////
+function createAPI(){
+	return new ParticleAPI(settings.apiUrl, {
+		accessToken: settings.access_token
+	});
+}
+
+function createAPIErrorResult({ error: e, message, json }){
+	const error = new VError(normalizedApiError(e), message);
+	error.asJSON = json;
+	return error;
+}
+

test/e2e/variable.e2e.js

@@ -5,7 +5,8 @@ const cli = require('../lib/cli');
 const {
 	DEVICE_ID,
 	DEVICE_NAME,
-	DEVICE_PLATFORM_NAME
+	DEVICE_PLATFORM_NAME,
+	PRODUCT_01_DEVICE_01_ID
 } = require('../lib/env');
 
 
@@ -116,6 +117,15 @@ describe('Variable Commands [@device]', () => {
 		expect(exitCode).to.equal(0);
 	});
 
+	it.skip('Gets a variable from a product device by name', async () => {
+		const args = ['get', PRODUCT_01_DEVICE_01_ID, 'version'];
+		const { stdout, stderr, exitCode } = await cli.run(args);
+
+		expect(stdout).to.equal('42');
+		expect(stderr).to.equal('');
+		expect(exitCode).to.equal(0);
+	});
+
 	it('Monitors a variable', async () => {
 		const args = ['variable', 'monitor', DEVICE_ID, 'version', '--delay', 1000];
 		const subprocess = cli.run(args);