publish command ignores --public flag since product events are never …

…public
particle-iot · Apr 14, 2020 · d522d53 · d522d53
1 parent 0471fe4
commit d522d53
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/cmd/publish.js b/src/cmd/publish.js
@@ -21,15 +21,15 @@ module.exports = class PublishCommand {
 	}
 
 	publishEvent({ private: isPrivate, public: isPublic, product, params: { event, data } }){
-		const setPrivate = isPublic ? false : isPrivate;
-		const visibility = setPrivate ? 'private' : 'public';
+		isPrivate = (isPublic && !product) ? false : isPrivate; // `isPrivate: true` by default see: src/cli/publish.js
+		const visibility = isPrivate ? 'private' : 'public';
 		let epilogue = `${visibility} event: ${event}`;
 
 		if (product){
 			epilogue += ` to product: ${product}`;
 		}
 
-		const publishEvent = createAPI().publishEvent(event, data, setPrivate, product);
+		const publishEvent = createAPI().publishEvent(event, data, isPrivate, product);
 		return this.showBusySpinnerUntilResolved(`Publishing ${epilogue}`, publishEvent)
 			.then(() => this.ui.stdout.write(`Published ${epilogue}${os.EOL}${os.EOL}`))
 			.catch(error => {

diff --git a/test/e2e/publish.e2e.js b/test/e2e/publish.e2e.js
@@ -102,11 +102,11 @@ describe('Publish Commands', () => {
 		expect(exitCode).to.equal(0);
 	});
 
-	it('Publishes a public product event', async () => {
+	it('Ignores `--public` flag when publishing a product event', async () => {
 		const args = ['publish', eventName, '--product', PRODUCT_01_ID, '--public'];
 		const { stdout, stderr, exitCode } = await cli.run(args);
 
-		expect(stdout).to.include(`Published public event: ${eventName} to product: ${PRODUCT_01_ID}${os.EOL}`);
+		expect(stdout).to.include(`Published private event: ${eventName} to product: ${PRODUCT_01_ID}${os.EOL}`);
 		expect(stderr).to.equal('');
 		expect(exitCode).to.equal(0);
 	});